[Rust] [Experiment] Trigonometry kernels#9313
Closed
nevi-me wants to merge 4 commits intoapache:masterfrom
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #9297
I was curious if (ab)using the
compute::unarykernel would perform better on slightly complex functions.I implemented the Haversine function, which calculates the distance between two geographic coordinates.
I then benchmarked an implementation that I tried to simplify and optimise with unary kernels, vs one that I'd have to write if I couldn't use the unary kernels for things like:
sin(x) * cos(x)would bemultiply(sin(x), cos(x)))The function that uses unary kernels for the above, is slightly faster.
I ran this on an M1 CPU, with the below options
The biggest benefit is from setting the
RUSTFLAGS, the non-null benches go 3-10% faster.